| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1402579513.1106.13.camel@debian> Date: Thu, 12 Jun 2014 21:25:13 +0800 From: Chen Yucong <slaoub@...il.com> To: Rik van Riel <riel@...hat.com> Cc: akpm@...ux-foundation.org, mgorman@...e.de, hannes@...xchg.org, mhocko@...e.cz, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] mm/vmscan.c: wrap five parameters into arg_container in shrink_page_list() On Thu, 2014-06-12 at 08:45 -0400, Rik van Riel wrote: > > shrink_page_list() has too many arguments that have already reached > ten. > > Some of those arguments and temporary variables introduces extra 80 > bytes > > on the stack. > > > > This patch wraps five parameters into arg_container and removes some > temporary > > variables, thus making shrink_page_list() to consume fewer stack > space. > > Won't the container with those arguments now live on the stack, > using up the same space that the variables used to take? > Of course, the container with those arguments live on the stack. One of the key reason for introducing this patch is to avoid passing five pointer arguments to shrink_page_list(). The arg_container also uses up the same space that the variables used to take. If the those arguments is wrapped to arg_container, we just need to pass one pointer to shrink_page_list instead of five. thx! cyc -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists