linux-kernel - Re: [PATCH] of: Add vendor 2nd prefix for Asahi Kasei Corp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5399C830.8070607@wwwdotorg.org>
Date:	Thu, 12 Jun 2014 09:33:04 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org
CC:	Mark Brown <broonie@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	ALSA Development Mailing List <alsa-devel@...a-project.org>,
	Linux-sh list <linux-sh@...r.kernel.org>,
	Magnus <magnus.damm@...il.com>, Simon <horms@...ge.net.au>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Ben Dooks <ben.dooks@...ethink.co.uk>
Subject: Re: [PATCH] of: Add vendor 2nd prefix for Asahi Kasei Corp

On 06/11/2014 06:53 PM, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> 
> Current vendor-prefixes.txt already has
> "ak" prefix for Asahi Kasei Corp by
> ae8c4209af2cec065fef15d200a42a04130799f7
> (of: Add vendor prefix for Asahi Kasei Corp.)
> 
> It went through the appropriate review process,
> and is already in use.
> But, almost all Asahi Kasei chip driver is
> using "asahi-kasei" prefix today.

I'm fine with this patch, but just wanted to comment on this part of the
commit description:

What is in the drivers isn't relevant; that's not what drives the ABI.
The issue is that some *DTs* use ak and some use asahi-kasei, so both
those need to be supported.

That said, we should document which one of the two prefixes is
preferred, and use this for any new AK binding.

It would also be nice to ensure the preferred prefix is in all drivers'
of_match_tables, and remove the deprecated prefix from all drivers'
of_match_tables *except* where there's already a DT file that references
the deprecated vendor prefix.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/