linux-kernel - Re: [PATCH] staging: alarm-dev: Support to Compile as Module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140612165530.GA14019@kroah.com>
Date:	Thu, 12 Jun 2014 09:55:30 -0700
From:	Greg Kroah-Hartman <greg@...ah.com>
To:	pramod.gurav.etc@...il.com
Cc:	linux-kernel@...r.kernel.org, Brian Swetland <swetland@...gle.com>
Subject: Re: [PATCH] staging: alarm-dev: Support to Compile as Module

On Thu, Jun 12, 2014 at 04:08:15PM +0530, pramod.gurav.etc@...il.com wrote:
> From: Pramod Gurav <pramod.gurav.etc@...il.com>
> 
> Currently this alarm-dev can be compiles only as built in
> driver. This adds support to compile it as module as well.
> This has dependancy on:
> https://lkml.org/lkml/2014/6/12/180
> 
> which exports symbol of alarmtimer function.
> 
> CC: Greg Kroah-Hartman <greg@...ah.com>
> CC: Brian Swetland <swetland@...gle.com>
> Signed-off-by: Pramod Gurav <pramod.gurav.etc@...il.com>
> ---
>  drivers/staging/android/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
> index 99e484f..c359317 100644
> --- a/drivers/staging/android/Kconfig
> +++ b/drivers/staging/android/Kconfig
> @@ -76,7 +76,7 @@ config ANDROID_LOW_MEMORY_KILLER
>  	  Registers processes to be killed when memory is low
>  
>  config ANDROID_INTF_ALARM_DEV
> -	bool "Android alarm driver"
> +	tristate "Android alarm driver"
>  	depends on RTC_CLASS
>  	default n
>  	---help---

Please resend the first patch (it's not a "trivial one") as part of this
patch series.

And do you ever really want this code as a module?  What will auto-load
it if needed?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/