linux-kernel - Re: [PATCH 5/9] staging: dgap: introduce dgap_tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Jun 2014 11:38:47 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	DaeSeok Youn <daeseok.youn@...il.com>
Cc:	devel <devel@...verdev.osuosl.org>,
	Lidza Louina <lidza.louina@...il.com>,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 5/9] staging: dgap: introduce dgap_tty_unregister()

On Fri, Jun 13, 2014 at 05:16:27PM +0900, DaeSeok Youn wrote:
> Hi, Dan
> 
> 
> 
> 2014-06-13 17:00 GMT+09:00 Dan Carpenter <dan.carpenter@...cle.com>:
> > On Fri, Jun 13, 2014 at 04:41:47PM +0900, Daeseok Youn wrote:
> >> dgap_tty_unregister() will unregister serial_driver
> >> and print_driver, and also free related variables.
> >>
> >
> > Introducing a static function without a caller will cause a GCC warning
> > about unused functions.
> >
> > Fold 5,7 and 8 together into one patch.  This is still "one thing per
> > patch" because they can't be done separately.
> OK. I will do. And then this series of patches will resend, right?

I'm afraid so.  New GCC warnings are against the rules even if you fix
it in a later patch.

Since you're redoing it, can I suggest that patch 8 should just move
the code to dgap_init_one() and change the dgap_firmware_load()
prototype and then another patch should add the error handling.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/