linux-kernel - Re: [PATCH] ALSA: au1x00: Use resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hk38lgppk.wl%tiwai@suse.de>
Date:	Fri, 13 Jun 2014 10:48:23 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Himangi Saraogi <himangi774@...il.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, julia.lawall@...6.fr
Subject: Re: [PATCH] ALSA: au1x00: Use resource_size

At Fri, 13 Jun 2014 03:32:07 +0530,
Himangi Saraogi wrote:
> 
> Use the function resource_size, which reduces the chance of introducing
> off-by-one errors in calculating the resource size.
> 
> The semantic patch that makes this change is as follows:
> 
> // <smpl>
> @@
> struct resource *res;
> @@
> 
> - (res->end - res->start) + 1
> + resource_size(res)
> // </smpl>
> 
> Signed-off-by: Himangi Saraogi <himangi774@...il.com>
> Acked-by: Julia Lawall <julia.lawall@...6.fr>

This was already fixed in sound git tree.


thanks,

Takashi

> ---
> Not compile tested.
>  sound/mips/au1x00.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/mips/au1x00.c b/sound/mips/au1x00.c
> index d10ef76..86583c7 100644
> --- a/sound/mips/au1x00.c
> +++ b/sound/mips/au1x00.c
> @@ -649,7 +649,7 @@ static int au1000_ac97_probe(struct platform_device *pdev)
>  
>  	err = -EBUSY;
>  	au1000->ac97_res_port = request_mem_region(r->start,
> -					r->end - r->start + 1, pdev->name);
> +					resource_size(r), pdev->name);
>  	if (!au1000->ac97_res_port) {
>  		snd_printk(KERN_ERR "ALSA AC97: can't grab AC97 port\n");
>  		goto out;
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/