linux-kernel - Re: [PATCH 9/9] serial/arc: Add DT based earlycon support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+wf-nwzw_sYk4FiZxRr2advvjkd7i32arqVAFptDeVGA@mail.gmail.com>
Date:	Thu, 12 Jun 2014 20:26:44 -0500
From:	Rob Herring <robherring2@...il.com>
To:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
Cc:	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, Paul Bolle <pebolle@...cali.nl>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	Francois.Bedard@...opsys.com
Subject: Re: [PATCH 9/9] serial/arc: Add DT based earlycon support

On Thu, Jun 12, 2014 at 5:31 AM, Vineet Gupta
<Vineet.Gupta1@...opsys.com> wrote:
> Signed-off-by: Vineet Gupta <vgupta@...opsys.com>
> ---

Nice series!

>  arch/arc/boot/dts/angel4.dts  | 3 ++-
>  drivers/tty/serial/arc_uart.c | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arc/boot/dts/angel4.dts b/arch/arc/boot/dts/angel4.dts
> index 6b57475967a6..e9fc270d1e0b 100644
> --- a/arch/arc/boot/dts/angel4.dts
> +++ b/arch/arc/boot/dts/angel4.dts
> @@ -17,7 +17,8 @@
>         interrupt-parent = <&intc>;
>
>         chosen {
> -               bootargs = "earlycon=arc_uart,mmio32,0xc0fc1000,115200n8 console=ttyARC0,115200n8";
> +               bootargs = "earlycon console=ttyARC0,115200n8";
> +               stdout-path = &arcuart0;

Just FYI, Grant has a series to pickup the normal console from
stdout-path which would mean you can remove console param as well.
I've kicked him to respin it.

Rob

>         };
>
>         aliases {
> diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
> index 435de4f2af3b..d9900cb3e7b6 100644
> --- a/drivers/tty/serial/arc_uart.c
> +++ b/drivers/tty/serial/arc_uart.c
> @@ -579,6 +579,7 @@ static int __init arc_early_console_setup(struct earlycon_device *dev,
>         return 0;
>  }
>  EARLYCON_DECLARE(arc_uart, arc_early_console_setup);
> +OF_EARLYCON_DECLARE(arc_uart, "snps,arc-uart", arc_early_console_setup);
>
>  #endif /* CONFIG_SERIAL_ARC_CONSOLE */
>
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/