linux-kernel - Re: [PATCH 1/2] ahci: Check and set 64-bit DMA mask for platform AHCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <539AF258.1080202@amd.com>
Date:	Fri, 13 Jun 2014 07:45:12 -0500
From:	Suravee Suthikulanit <suravee.suthikulpanit@....com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	<tj@...nel.org>, <b.zolnierkie@...sung.com>
CC:	<hdegoede@...hat.com>, <lho@....com>, <tphan@....com>,
	<stripathi@....com>, <linux-ide@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ahci: Check and set 64-bit DMA mask for platform
 AHCI driver

On 6/12/2014 12:47 PM, Sergei Shtylyov wrote:
>> diff --git a/drivers/ata/libahci_platform.c
>> b/drivers/ata/libahci_platform.c
>> index 3a5b4ed..a958a2b 100644
>> --- a/drivers/ata/libahci_platform.c
>> +++ b/drivers/ata/libahci_platform.c
>> @@ -364,6 +364,19 @@ int ahci_platform_init_host(struct
>> platform_device *pdev,
>>               ap->ops = &ata_dummy_port_ops;
>>       }
>>
>> +    if (hpriv->cap & HOST_CAP_64) {
>> +        rc = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(64));
>> +        if (rc) {
>> +            rc = dma_coerce_mask_and_coherent(dev,
>> +                              DMA_BIT_MASK(32));
>> +            if (rc) {
>> +                dev_err(dev, "Failed to enable 64-bit DMA.\n");
>
>     Not 32-bit?
Actually, I intended to say 64 since this is supposed to be setting up 
64-bit DMA mask. Or we could just say failed to set up DMA mask.

Suravee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/