lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 Jun 2014 16:01:55 +0200 From: Robert Richter <rric@...nel.org> To: Tomasz Nowicki <tomasz.nowicki@...aro.org> Cc: rjw@...ysocki.net, lenb@...nel.org, tony.luck@...el.com, bp@...en8.de, m.chehab@...sung.com, bp@...e.de, linux-edac@...r.kernel.org, x86@...nel.org, linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, linaro-acpi@...ts.linaro.org Subject: Re: [PATCH v3 2/5] acpi, apei, ghes: Introduce ARCH_HAS_ACPI_APEI_NMI to make NMI error notification a GHES feature. On 13.06.14 13:02:57, Tomasz Nowicki wrote: > Currently APEI depends on x86 architecture. It is because of NMI hardware > error notification of GHES which is currently supported by x86 only. > However, many other APEI features can be still used perfectly by other > architectures. > > This commit adds ARCH_HAS_ACPI_APEI_NMI which will be used in next patches > for NMI related code isolation in ghes.c file. Only NMI error notification > feature depends on x86 so let it be hard selected for x86 arch. > > Signed-off-by: Tomasz Nowicki <tomasz.nowicki@...aro.org> > --- > arch/x86/Kconfig | 1 + > drivers/acpi/apei/Kconfig | 8 +++++++- > 2 files changed, 8 insertions(+), 1 deletion(-) Apart from merging the patch with later ones this change looks fine to me > +config ARCH_HAS_ACPI_APEI_NMI > + bool > + help > + Firmware first mode can use NMI notification mechanism to report errors > + to operating system. This feature is currently supported by X86 > + architecture only. > + Maybe the help description could be removed, it is not used anywhere in a dialog. At least the reference to x86 should be removed (if the option is used for another arch the text will be wrong and need to be changed again). -Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists