linux-kernel - Re: [PATCH] of: avoid format string parsing in kobject names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKR4Eo7QR=_N-8Y89KkShBB7yk6_vkUhvh6uOXDz0vuyw@mail.gmail.com>
Date:	Fri, 13 Jun 2014 10:30:33 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Rob Herring <robherring2@...il.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH] of: avoid format string parsing in kobject names

On Fri, Jun 13, 2014 at 7:55 AM, Rob Herring <robherring2@...il.com> wrote:
> On Tue, Jun 10, 2014 at 11:57 AM, Kees Cook <keescook@...omium.org> wrote:
>> This makes sure a format string cannot leak into the kobject name that
>> is constructed. (And splits the >80 character line.)
>>
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>
> Applied.
>
> This seems like a non-obvious thing to do, but I guess most people
> aren't dealing directly with kobjects.

Yeah, it's really unlikely this could get reached, but I just keep
cleaning this up any time I see them just to be safe. :)

Thanks!

-Kees


-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/