linux-kernel - Re: [PATCHv7 2/5] mailbox: Introduce framework for mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140613204027.GC5099@sirena.org.uk>
Date:	Fri, 13 Jun 2014 21:40:27 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Jassi Brar <jaswinder.singh@...aro.org>
Cc:	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	mporter@...aro.org, patches@...aro.org, bjorn@...o.se,
	ashwin.chaugule@...aro.org, gregkh@...uxfoundation.org,
	s-anna@...com, loic.pallardy@...com, lftan.linux@...il.com,
	slapdau@...oo.com.au, courtney.cavin@...ymobile.com,
	pawel.moll@....com, robh+dt@...nel.org, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, arnd@...db.de, joshc@...eaurora.org,
	linus.walleij@...aro.org, galak@...eaurora.org, ks.giri@...sung.com
Subject: Re: [PATCHv7 2/5] mailbox: Introduce framework for mailbox

On Thu, Jun 12, 2014 at 10:31:19PM +0530, Jassi Brar wrote:

A couple of tiny nits, I'll send followup patches for these.

> +bool mbox_client_peek_data(struct mbox_chan *chan)
> +{
> +	if (chan->mbox->ops->peek_data)
> +		return chan->mbox->ops->peek_data(chan);
> +
> +	return false;
> +}
> +EXPORT_SYMBOL_GPL(mbox_client_peek_data);

This isn't declared in the header to allow users to use it.

> +struct mbox_chan *mbox_request_channel(const struct mbox_client *cl)

> +	spin_lock_irqsave(&chan->lock, flags);
> +	chan->msg_free = 0;
> +	chan->msg_count = 0;
> +	chan->active_req = NULL;
> +	chan->cl = cl;

chan->cl is non-const but cl is const so this assignment is invalid.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)