linux-kernel - Re: [PATCH] i2c-taos-evm: Use module_serio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140613232300.45ebf96f@endymion.delvare>
Date:	Fri, 13 Jun 2014 23:23:00 +0200
From:	Jean Delvare <jdelvare@...e.de>
To:	Christoph Jaeger <christophjaeger@...ux.com>
Cc:	wsa@...-dreams.de, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c-taos-evm: Use module_serio_driver()

On Fri, 13 Jun 2014 21:52:24 +0200, Christoph Jaeger wrote:
> Get rid of some boilerplate code by using module_serio_driver().
> 
> Signed-off-by: Christoph Jaeger <christophjaeger@...ux.com>
> ---
>  drivers/i2c/busses/i2c-taos-evm.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c
> index 0576026..10855a0 100644
> --- a/drivers/i2c/busses/i2c-taos-evm.c
> +++ b/drivers/i2c/busses/i2c-taos-evm.c
> @@ -311,19 +311,8 @@ static struct serio_driver taos_drv = {
>  	.interrupt	= taos_interrupt,
>  };
>  
> -static int __init taos_init(void)
> -{
> -	return serio_register_driver(&taos_drv);
> -}
> -
> -static void __exit taos_exit(void)
> -{
> -	serio_unregister_driver(&taos_drv);
> -}
> +module_serio_driver(taos_drv);
>  
>  MODULE_AUTHOR("Jean Delvare <jdelvare@...e.de>");
>  MODULE_DESCRIPTION("TAOS evaluation module driver");
>  MODULE_LICENSE("GPL");
> -
> -module_init(taos_init);
> -module_exit(taos_exit);

Reviewed-by: Jean Delvare <jdelvare@...e.de>

Thanks,
-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/