linux-kernel - Re: [PATCH v2] mm/vmscan.c: wrap five parameters into shrink_result for reducing the stack consumption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1402636875.1232.13.camel@debian>
Date:	Fri, 13 Jun 2014 13:21:15 +0800
From:	Chen Yucong <slaoub@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	mgorman@...e.de, hannes@...xchg.org, mhocko@...e.cz,
	riel@...hat.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm/vmscan.c: wrap five parameters into
 shrink_result for reducing the stack consumption

On Thu, 2014-06-12 at 21:40 -0700, Andrew Morton wrote:
> On Fri, 13 Jun 2014 12:36:31 +0800 Chen Yucong <slaoub@...il.com> wrote:
> 
> > @@ -1148,7 +1146,8 @@ unsigned long reclaim_clean_pages_from_list(struct zone *zone,
> >  		.priority = DEF_PRIORITY,
> >  		.may_unmap = 1,
> >  	};
> > -	unsigned long ret, dummy1, dummy2, dummy3, dummy4, dummy5;
> > +	unsigned long ret;
> > +	struct shrink_result dummy = { };
> 
> You didn't like the idea of making this static?
Sorry! It's my negligence.
If we make dummy static, it can help us save more stack.

without change:  
0xffffffff810aede8 reclaim_clean_pages_from_list []:	184
0xffffffff810aeef8 reclaim_clean_pages_from_list []:	184

with change: struct shrink_result dummy = {};
0xffffffff810aed6c reclaim_clean_pages_from_list []:	152
0xffffffff810aee68 reclaim_clean_pages_from_list []:	152

with change: static struct shrink_result dummy ={};
0xffffffff810aed69 reclaim_clean_pages_from_list []:	120
0xffffffff810aee4d reclaim_clean_pages_from_list []:	120

thx!
cyc

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/