linux-kernel - Re: [PATCH v4] lib: add size unit t/p/e to memparse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1402639424.6709.4.camel@localhost.localdomain>
Date:	Fri, 13 Jun 2014 14:03:44 +0800
From:	Gui Hecheng <guihc.fnst@...fujitsu.com>
To:	Brendan Hide <brendan@...ftspirit.co.za>
CC:	<linux-kernel@...r.kernel.org>, <linux-btrfs@...r.kernel.org>,
	<akpm@...ux-foundation.org>
Subject: Re: [PATCH v4] lib: add size unit t/p/e to memparse

On Fri, 2014-06-13 at 07:55 +0200, Brendan Hide wrote:
> On 13/06/14 03:42, Gui Hecheng wrote:
> > For modern filesystems such as btrfs, t/p/e size level operations
> > are common.
> > add size unit t/p/e parsing to memparse
> >
> > Signed-off-by: Gui Hecheng <guihc.fnst@...fujitsu.com>
> > ---
> > changelog
> > 	v1->v2: replace kilobyte with kibibyte, and others
> > 	v2->v3: add missing unit "bytes" in comment
> > 	v3->v4: remove idiotic name for K,M,G,P,T,E
> > ---
> >   lib/cmdline.c | 15 ++++++++++-----
> >   1 file changed, 10 insertions(+), 5 deletions(-)
> >
> > diff --git a/lib/cmdline.c b/lib/cmdline.c
> > index d4932f7..76a712e 100644
> > --- a/lib/cmdline.c
> > +++ b/lib/cmdline.c
> > @@ -121,11 +121,7 @@ EXPORT_SYMBOL(get_options);
> >    *	@retptr: (output) Optional pointer to next char after parse completes
> >    *
> >    *	Parses a string into a number.  The number stored at @ptr is
> > - *	potentially suffixed with %K (for kilobytes, or 1024 bytes),
> > - *	%M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
> > - *	1073741824).  If the number is suffixed with K, M, or G, then
> > - *	the return value is the number multiplied by one kilobyte, one
> > - *	megabyte, or one gigabyte, respectively.
> > + *	potentially suffixed with K, M, G, T, P, E.
> >    */
> >   
> >   unsigned long long memparse(const char *ptr, char **retptr)
> > @@ -135,6 +131,15 @@ unsigned long long memparse(const char *ptr, char **retptr)
> >   	unsigned long long ret = simple_strtoull(ptr, &endptr, 0);
> >   
> >   	switch (*endptr) {
> > +	case 'E':
> > +	case 'e':
> > +		ret <<= 10;
> > +	case 'P':
> > +	case 'p':
> > +		ret <<= 10;
> > +	case 'T':
> > +	case 't':
> > +		ret <<= 10;
> >   	case 'G':
> >   	case 'g':
> >   		ret <<= 10;
> Ah, I see - you've removed all reference to their names. That's good too. :)
> 
Thank you for your review!
I think maybe more people would like cleaner things in the kernel.

-Gui

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/