linux-kernel - Re: [PATCH] serial: samsung: Fix compile error with SERIAL_SAMSUNG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1402778036.2756.24.camel@joe-AO725>
Date:	Sat, 14 Jun 2014 13:33:56 -0700
From:	Joe Perches <joe@...ches.com>
To:	Christian Engelmayer <cengelma@....at>
Cc:	linux-serial@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, Jingoo Han <jg1.han@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: samsung: Fix compile error with
 SERIAL_SAMSUNG_DEBUG

Greg?  Can you please apply this soon?

Thanks.

On Sat, 2014-06-14 at 22:07 +0200, Christian Engelmayer wrote:
> Commit e4ac92d (serial: samsung: Neaten dbg uses) contains a typo in the
> changed dbg() function regarding the name of the used character buffer.
> This breaks the build if actually compiled with CONFIG_SERIAL_SAMSUNG_DEBUG.
> 
> Signed-off-by: Christian Engelmayer <cengelma@....at>
> ---
> Compile tested. Applies against branch tty-next in tree
> git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> ---
>  drivers/tty/serial/samsung.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 3293377..c1d3ebd 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -66,7 +66,7 @@ static void dbg(const char *fmt, ...)
>  	char buff[256];
>  
>  	va_start(va, fmt);
> -	vscnprintf(buff, sizeof(buf), fmt, va);
> +	vscnprintf(buff, sizeof(buff), fmt, va);
>  	va_end(va);
>  
>  	printascii(buff);



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/