| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140614224222.GE1389@xo-6d-61-c0.localdomain> Date: Sun, 15 Jun 2014 00:42:22 +0200 From: Pavel Machek <pavel@....cz> To: Janne Kanniainen <janne.kanniainen@...il.com> Cc: jkosina@...e.cz, johan@...nel.org, cooloney@...il.com, linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org, linux-usb@...r.kernel.org, linux-input@...r.kernel.org Subject: Re: [PATCH v5] leds: USB: HID: Add support for MSI GT683R led panels On Thu 2014-06-12 23:34:12, Janne Kanniainen wrote: > This driver adds support for USB controlled led panels that exists in > MSI GT683R laptop Hi! > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-class-hid-driver-gt683r > @@ -0,0 +1,10 @@ > +What: /sys/class/hidraw/<hidraw>/device/state > +Date: Jun 2014 > +KernelVersion: 3.15 > +Contact: Janne Kanniainen <janne.kanniainen@...il.com> > +Description: > + Set the mode of LEDs > + > + 0 - normal > + 1 - audio > + 2 - breathing THat's some strange interface. Don't we normally use led triggers for this? And the mode of the LED should really be in /sys/class/leds, not in hidraw somewhere... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists