linux-kernel - Re: [PATCH v2 2/2] Add support for Compact (Bluetooth|USB) keyboard with Trackpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1406140731420.1321@pobox.suse.cz>
Date:	Sat, 14 Jun 2014 07:33:41 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Antonio Ospite <ao2@....it>
cc:	Jamie Lentin <jm@...tin.co.uk>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] Add support for Compact (Bluetooth|USB) keyboard
 with Trackpoint

On Fri, 13 Jun 2014, Antonio Ospite wrote:

> > Previously the tpkbd driver had various functions marked "_tp" to indicate 
> > that it's for the "mouse" half of the keyboard as the kernel sees it, 
> > however it does nothing special with the keyboard half. I was intending 
> > (somewhat sloppily) to repurpose this into having versions of each 
> > function for each keyboard, and a common function to switch between them. 
> > Should make it fairly easy to add extra keyboards in the future.
> > 
> > The problem, as ever, is choosing decent names for them. It should 
> > probably be either:-
> > 
> > * tpkbd_input_mapping_usbkbd
> > * tpkbd_input_mapping_compactkbd
> > ...and tpkbd_input_mapping switches between them
> > 
> > or rename the driver to hid-lenovo and do:-
> > 
> 
> I am OK with a rename. Most files in drivers/hid are per-vendor after
> all. Jiri?

Fine by me; the module doesn't take any parameters, so we are not risking 
introducing regression for people who'd have put parameter settings in 
modprobe.conf or some such.

So please go ahead with the rename.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/