linux-kernel - Re: [PATCH-v2 4/4] random: clean up interrupt entropy accounting for archs w/o cycle counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140614072849.27887.qmail@ns.horizon.com>
Date:	14 Jun 2014 03:28:49 -0400
From:	"George Spelvin" <linux@...izon.com>
To:	linux-kernel@...r.kernel.org, tytso@....edu
Cc:	linux@...izon.com
Subject: Re: [PATCH-v2 4/4] random: clean up interrupt entropy accounting for archs w/o cycle counters

+	if (cycles || (fast_pool->notimer_count >= 32))
+		credit++;

Ah, this addresses my concern about too few interrupts, too.  If the
(non-timer) interrupt rate is less than 32/second, you'll never get any
credit.

(If you want to support this mode of operation and still have a non-zero
credit rate, move the clear of notimer_count into this condition.  Then
you get 1 bit per 32 non-timer interrupts no matter how slow.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/