linux-kernel - Re: [PATCH v2 3/7] drm: add Atmel HLCDC Display Controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <539DB51D.5080204@free-electrons.com>
Date:	Sun, 15 Jun 2014 17:00:45 +0200
From:	Boris BREZILLON <boris.brezillon@...e-electrons.com>
To:	jjhiblot@...phandler.com,
	Thierry Reding <thierry.reding@...il.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	David Airlie <airlied@...ux.ie>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>
CC:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-pwm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 3/7] drm: add Atmel HLCDC Display Controller support

Hello JJ,

On 15/06/2014 11:32, Jean-Jacques Hiblot wrote:
>
> On 06/09/2014 06:04 PM, Boris BREZILLON wrote:
>> The Atmel HLCDC (High LCD Controller) IP available on some Atmel SoCs (i.e.
>> at91sam9n12, at91sam9x5 family or sama5d3 family) provides a display
>> controller device.
>>
>> This display controller support at least one primary plane and might
>> provide several overlays and an hardware cursor depending on the IP
>> version.
>>
>> Signed-off-by: Boris BREZILLON <boris.brezillon@...e-electrons.com>
>> ---

[...]

>> +	    vm.vfront_porch > 0x40 || vm.vfront_porch < 0 ||
>> +	    vm.vback_porch > 0x40 || vm.vback_porch < 0 ||
>> +	    vm.hfront_porch > 0x200 || vm.hfront_porch < 0 ||
>> +	    vm.hback_porch > 0x200 || vm.hback_porch < 0 ||
>> +	    mode->hdisplay > 2048 || mode->hdisplay < 0 ||
>> +	    mode->vdisplay > 2048 || mode->vdisplay < 0)
>> +		return -EINVAL;
>> +
>> +	regmap_write(regmap, ATMEL_HLCDC_CFG(1),
>> +		     (vm.hsync_len - 1) | ((vm.vsync_len - 1) << 16));
>> +
>> +	regmap_write(regmap, ATMEL_HLCDC_CFG(2),
>> +		     (vm.vfront_porch - 1) | ((vm.vback_porch - 1) << 16));
> Acording to the datasheet, it's vm.vback_porch instead of
> (vm.vback_porch -1).

Oh, nice catch!

I'll check with Atmel that this is not a typo in their datasheet,
because all other fields need the minus 1.

Thanks for your review.

Best Regards,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/