linux-kernel - [PATCH] staging: rtl8192u: r8192U_core.c: Cleaning up unclear and confusing code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1402845246-28125-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Date:	Sun, 15 Jun 2014 17:14:05 +0200
From:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
Cc:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Ana Rey <anarey@...il.com>,
	Andrea Merello <andrea.merello@...il.com>,
	Teodora Baluta <teobaluta@...il.com>,
	Chi Pham <fempsci@...il.com>,
	Himangi Saraogi <himangi774@...il.com>,
	Xenia Ragiadakou <burzalodowa@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH] staging: rtl8192u: r8192U_core.c:  Cleaning up unclear and confusing code  

Removes confusing and unclear code. 
Using memcpy to set a pointer, what is the point?
The use of &= instead of & fills no benefit in this case.
None of these is a direct error, but I think you should replace the confusing code.

Rickard Strandqvist (1):
  staging: rtl8192u: r8192U_core.c:  Cleaning up unclear and confusing code

 drivers/staging/rtl8192u/r8192U_core.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/