[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1565726.7T8Lt3Xc6J@vostro.rjw.lan>
Date: Mon, 16 Jun 2014 01:04:42 +0200
From: "Rafael J. Wysocki" <rjw@...ysocki.net>
To: "H. Peter Anvin" <hpa@...or.com>
Cc: Kees Cook <keescook@...omium.org>, Pavel Machek <pavel@....cz>,
LKML <linux-kernel@...r.kernel.org>,
Randy Dunlap <rdunlap@...radead.org>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"x86@...nel.org" <x86@...nel.org>, Len Brown <len.brown@...el.com>,
Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
linux-pm@...r.kernel.org
Subject: Re: [PATCH 0/2] make kASLR vs hibernation boot-time selectable
On Saturday, June 14, 2014 09:41:19 AM H. Peter Anvin wrote:
> On 06/13/2014 05:39 PM, Rafael J. Wysocki wrote:
> >
> > -#define RESTORE_MAGIC 0x0123456789ABCDEFUL
> > +#define RESTORE_MAGIC 0x0123456789ABCDF0UL
> >
>
> <bikeshed>
>
> Please don't pick numbers like this for magic numbers... *everyone else
> does, too.* In general, picking a random number is a good starting
> point; for extra bonus make sure it has at least one invalid UTF-8
> sequence in it (so it cannot be confused with either ASCII or UTF-8 text.)
>
> </bikeshed>
OK, when we find out how to make hibernation work with the address space
randomization.
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists