linux-kernel - Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140614.235300.1228145928404410306.davem@davemloft.net>
Date:	Sat, 14 Jun 2014 23:53:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xerofoify@...il.com
Cc:	andriy.shevchenko@...ux.intel.com, dvhart@...ux.intel.com,
	jeffrey.t.kirsher@...el.com, ast@...mgrid.com, dborkman@...hat.com,
	bhutchings@...arflare.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Missing return check against Null for return value of
 netdev_alloc_dev_skb()

From: Nick <xerofoify@...il.com>
Date: Sun, 15 Jun 2014 00:05:39 -0400

> Signed-off-by: Nick <xerofoify@...il.com>
> ---
>  drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> index 73e6683..704cf63 100644
> --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> @@ -1515,6 +1515,8 @@ static void pch_gbe_alloc_tx_buffers(struct pch_gbe_adapter *adapter,
>  	for (i = 0; i < tx_ring->count; i++) {
>  		buffer_info = &tx_ring->buffer_info[i];
>  		skb = netdev_alloc_skb(adapter->netdev, bufsz);
> +		if (!skb)
> +			return NULL;

You didn't even compile test this.

The function has a void return type, you can't return NULL.

Furthermore, you have to adjust things so that the caller knows that
this operation failed, because the device cannot be brought up
successfully unless all the TX buffer slots get allocated properly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/