linux-kernel - Re: [PATCH -next 22/26] qla2xxx: Use dma_zalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F5D084D6342F9B479C34599BB0A03E4D01284FFE36@AVMB1.qlogic.org>
Date:	Mon, 16 Jun 2014 06:16:50 +0000
From:	Saurav Kashyap <saurav.kashyap@...gic.com>
To:	Joe Perches <joe@...ches.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
CC:	Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@...gic.com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH -next 22/26] qla2xxx: Use dma_zalloc_coherent

Acked-by: Saurav Kashyap <saurav.kashyap@...gic.com>


>Use the zeroing function instead of dma_alloc_coherent & memset(,0,)
>
>Signed-off-by: Joe Perches <joe@...ches.com>
>---
> drivers/scsi/qla2xxx/qla_init.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/scsi/qla2xxx/qla_init.c
>b/drivers/scsi/qla2xxx/qla_init.c
>index e218441..46990f4 100644
>--- a/drivers/scsi/qla2xxx/qla_init.c
>+++ b/drivers/scsi/qla2xxx/qla_init.c
>@@ -1526,8 +1526,8 @@ try_fce:
> 			    FCE_SIZE, ha->fce, ha->fce_dma);
> 
> 		/* Allocate memory for Fibre Channel Event Buffer. */
>-		tc = dma_alloc_coherent(&ha->pdev->dev, FCE_SIZE, &tc_dma,
>-		    GFP_KERNEL);
>+		tc = dma_zalloc_coherent(&ha->pdev->dev, FCE_SIZE, &tc_dma,
>+					 GFP_KERNEL);
> 		if (!tc) {
> 			ql_log(ql_log_warn, vha, 0x00be,
> 			    "Unable to allocate (%d KB) for FCE.\n",
>@@ -1535,7 +1535,6 @@ try_fce:
> 			goto try_eft;
> 		}
> 
>-		memset(tc, 0, FCE_SIZE);
> 		rval = qla2x00_enable_fce_trace(vha, tc_dma, FCE_NUM_BUFFERS,
> 		    ha->fce_mb, &ha->fce_bufs);
> 		if (rval) {
>@@ -1560,8 +1559,8 @@ try_eft:
> 			    EFT_SIZE, ha->eft, ha->eft_dma);
> 
> 		/* Allocate memory for Extended Trace Buffer. */
>-		tc = dma_alloc_coherent(&ha->pdev->dev, EFT_SIZE, &tc_dma,
>-		    GFP_KERNEL);
>+		tc = dma_zalloc_coherent(&ha->pdev->dev, EFT_SIZE, &tc_dma,
>+					 GFP_KERNEL);
> 		if (!tc) {
> 			ql_log(ql_log_warn, vha, 0x00c1,
> 			    "Unable to allocate (%d KB) for EFT.\n",
>@@ -1569,7 +1568,6 @@ try_eft:
> 			goto cont_alloc;
> 		}
> 
>-		memset(tc, 0, EFT_SIZE);
> 		rval = qla2x00_enable_eft_trace(vha, tc_dma, EFT_NUM_BUFFERS);
> 		if (rval) {
> 			ql_log(ql_log_warn, vha, 0x00c2,
>-- 
>1.8.1.2.459.gbcd45b4.dirty
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/