lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 16 Jun 2014 09:43:47 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>
cc:	Matthias Brugger <matthias.bgg@...il.com>,
	linux-kernel@...r.kernel.org, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	rdunlap@...radead.org, linux@....linux.org.uk,
	grant.likely@...aro.org, thierry.reding@...il.com,
	florian.vaussard@...l.ch, jic23@...nel.org, jason@...edaemon.net,
	andrew@...n.ch, silvio.fricke@...il.com, heiko.stuebner@...com,
	olof@...om.net, sebastian.hesselbarth@...il.com,
	sboyd@...eaurora.org, gregory.clement@...e-electrons.com,
	arnd@...db.de, robherring2@...il.com, marc.zyngier@....com,
	maxime.ripard@...e-electrons.com, soren.brinkmann@...inx.com,
	shawn.guo@...escale.com, anders.berg@....com,
	linus.walleij@...aro.org, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v8 2/7] clocksource: Add support for the Mediatek SoCs

On Sun, 15 Jun 2014, Daniel Lezcano wrote:

> On 06/11/2014 08:14 PM, Thomas Gleixner wrote:
> > On Wed, 11 Jun 2014, Matthias Brugger wrote:
> > > +static void mtk_clkevt_mode(enum clock_event_mode mode,
> > > +				struct clock_event_device *clk)
> > > +{
> > > +	struct mtk_clock_event_device *evt = to_mtk_clk(clk);
> > > +
> > > +	mtk_clkevt_time_stop(evt, GPT_CLK_EVT);
> > > +
> > > +	switch (mode) {
> > > +	case CLOCK_EVT_MODE_PERIODIC:
> > > +		mtk_clkevt_time_setup(evt, evt->ticks_per_jiffy, GPT_CLK_EVT);
> > > +		mtk_clkevt_time_start(evt, true, GPT_CLK_EVT);
> > > +		break;
> > > +	case CLOCK_EVT_MODE_ONESHOT:
> > > +		mtk_clkevt_time_start(evt, false, GPT_CLK_EVT);
> > 
> > Why start the timer here? The code will call set next event right away.
> > 
> > > +		break;
> > > +	case CLOCK_EVT_MODE_UNUSED:
> > > +	case CLOCK_EVT_MODE_SHUTDOWN:
> > > +	default:
> > > +		/* No more interrupts will occur as source is disabled */
> > > +		break;
> > > +	}
> > > +}
> > 
> > Looks good otherwise.
> 
> Hi Thomas,
> 
> Can I consider the 8.1 patch (the one taking into account your comment) as
> acked-by ?

Yes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists