| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140616075556.GZ5500@mwanda> Date: Mon, 16 Jun 2014 10:55:56 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Martin Kepplinger <martink@...teo.de> Cc: gregkh@...uxfoundation.org, devel@...verdev.osuosl.org, forest@...ttletooquiet.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: vt6655: preserve address space by not casting On Fri, Jun 13, 2014 at 12:11:51PM +0200, Martin Kepplinger wrote: > Fix the sparse error: cast removes address space of expression. > --- > Is that even correct? It's correct but not complete. vt6655 impliment their own versions of ethtool_ioctl() when they should be using the standard versions. The vt6655 version of ethtool_ioctl() should be annotated so it's marked that the second parameter is marked as a __user pointer. It doesn't print a Sparse warning because at a certain point Sparse just says: "warning: too many warnings" and gives up. > I haven't signed-off on it yet. > ethtool_ioctl() takes a (void *) as user data, dereferenced and assigend to u32. > applies to next-20140611 It doesn't dereference the pointer. You are getting mixed up with the vt6656 version of ethtool_ioctl() I think? You're not allowed to dereference __user pointers. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists