linux-kernel - Re: [PATCH] staging: slicoss: Fix coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140616081350.GC5500@mwanda>
Date:	Mon, 16 Jun 2014 11:13:50 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Benedict Boerger <benedict.boerger@...tu-dortmund.de>,
	matlackdavid@...il.com, devel@...verdev.osuosl.org,
	peter.p.waskiewicz.jr@...el.com, linux-kernel@...r.kernel.org,
	liodot@...il.com, charrer@...critech.com,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] staging: slicoss: Fix coding style issue

On Fri, Jun 13, 2014 at 10:04:35AM -0700, Greg KH wrote:
> On Fri, Jun 13, 2014 at 05:52:33PM +0200, Benedict Boerger wrote:
> > Fix a coding style issue found by checkpatch.pl.
> > Use ether_addr_copy instead of memcpy.
> > 
> > Done to complete a eudyptula task.
> > 
> > Signed-off-by: Benedict Boerger <benedict.boerger@...tu-dortmund.de>
> > 
> > ---
> >  drivers/staging/slicoss/slicoss.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> > index 48841e7..02807a3 100644
> > --- a/drivers/staging/slicoss/slicoss.c
> > +++ b/drivers/staging/slicoss/slicoss.c
> > @@ -1790,7 +1790,7 @@ static int slic_mcast_add_list(struct adapter *adapter, char *address)
> >  	if (mcaddr == NULL)
> >  		return 1;
> >  
> > -	memcpy(mcaddr->address, address, ETH_ALEN);
> > +	ether_addr_copy(mcaddr->address, address);
> >  
> >  	mcaddr->next = adapter->mcastaddrs;
> >  	adapter->mcastaddrs = mcaddr;
> 
> Are you sure this is correct?  It's not always a one-to-one replacement
> from what I have been told.

I hate this checkpatch.pl warning because it just encourages people to
add bugs.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/