linux-kernel - Re: [PATCH] Frees gate after if statement in clk-sunxi.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140616081538.GV23430@n2100.arm.linux.org.uk>
Date:	Mon, 16 Jun 2014 09:15:39 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Nick Krause <xerofoify@...il.com>
Cc:	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Emilio López <emilio@...pez.com.ar>,
	Mike Turquette <mturquette@...aro.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] Frees gate after if statement in clk-sunxi.c

On Sun, Jun 15, 2014 at 11:31:41PM -0400, Nick Krause wrote:
> Seems the bug is fixed , don't worry about resent patch.
> Thanks Nick
> 
> On Sun, Jun 15, 2014 at 11:21 PM, Nick Krause <xerofoify@...il.com> wrote:
> > @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct
> > device_node *node)
> >         u32 rate;
> >
> >         if (of_property_read_u32(node, "clock-frequency", &rate))
> > +               kfree(gate);
> >                 return;

In any case, the kernel is not coded in Python.

C uses braces { } to enclose blocks of code, and does not care about
indentation - indentation is meaningless to C.  Python purely identifies
blocks of code by indentation alone.

Please take account of the programming language when creating patches.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/