[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <539EB0E2.1080307@collabora.co.uk>
Date: Mon, 16 Jun 2014 10:54:58 +0200
From: Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To: Lee Jones <lee.jones@...aro.org>
CC: Samuel Ortiz <sameo@...ux.intel.com>,
Mark Brown <broonie@...nel.org>,
Mike Turquette <mturquette@...aro.org>,
Liam Girdwood <lgirdwood@...il.com>,
Alessandro Zummo <a.zummo@...ertech.it>,
Kukjin Kim <kgene.kim@...sung.com>,
Doug Anderson <dianders@...omium.org>,
Olof Johansson <olof@...om.net>,
Sjoerd Simons <sjoerd.simons@...labora.co.uk>,
Daniel Stone <daniels@...labora.com>,
Tomeu Vizoso <tomeu.vizoso@...labora.com>,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] clk: Add driver for Maxim 77802 PMIC clocks
Hello Lee,
On 06/16/2014 10:44 AM, Lee Jones wrote:
>> The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
>> Low Jitter Mode. This patch adds support for these two clocks.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>
>> ---
>> .../devicetree/bindings/clock/maxim,max77802.txt | 40 ++++
>> drivers/clk/Kconfig | 6 +
>> drivers/clk/Makefile | 1 +
>> drivers/clk/clk-max77802.c | 253 +++++++++++++++++++++
>> drivers/mfd/max77802.c | 3 +
>> include/dt-bindings/clock/maxim,max77802.h | 22 ++
>> 6 files changed, 325 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/maxim,max77802.txt
>> create mode 100644 drivers/clk/clk-max77802.c
>> create mode 100644 include/dt-bindings/clock/maxim,max77802.h
>
> [...]
>
>> diff --git a/drivers/mfd/max77802.c b/drivers/mfd/max77802.c
>> index 59696dd..33e8023 100644
>> --- a/drivers/mfd/max77802.c
>> +++ b/drivers/mfd/max77802.c
>> @@ -35,6 +35,9 @@
>>
>> static const struct mfd_cell max77802_devs[] = {
>> { .name = "max77802-pmic", },
>> +#if defined(CONFIG_COMMON_CLK_MAX77802)
>
> No, don't do that. If COMMON_CLK_MAX77802 is not defined it just
> won't be matched, which is enough to ensure it won't be probed.
>
Thanks a lot for the explanation.
I'll send a v2 patch-set soon which has changes based on the feedback from Mark
and Krzysztof. I'll take this point into account as well.
>> + { .name = "max77802-clk", },
>> +#endif
>> };
>
> [...]
>
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists