lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 16 Jun 2014 11:11:17 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH] tools lib traceevent: Clean up format of args in
 cfg80211 plugin

On Thu, Jun 12, 2014 at 07:44:20PM -0400, Steven Rostedt wrote:
> While synchronizing what's in trace-cmd vs what's in perf, I came
> across a change that was made when entering the cfg80211 plugin into
> the tools/lib/traceevent directory. The function prototype went from:
> 
> static unsigned long long process___le16_to_cpup(struct trace_seq *s,
> 						 unsigned long long *args)
> 
> to:
> 
> static unsigned long long
> process___le16_to_cpup(struct trace_seq *s,
> 		       unsigned long long *args)
> 
> I can understand the line break after the long long, but there's no
> reason to keep args on a separate line.
> 
> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>

queued, thanks

jirka

> ---
> diff --git a/tools/lib/traceevent/plugin_cfg80211.c b/tools/lib/traceevent/plugin_cfg80211.c
> index c066b25..4592d84 100644
> --- a/tools/lib/traceevent/plugin_cfg80211.c
> +++ b/tools/lib/traceevent/plugin_cfg80211.c
> @@ -5,8 +5,7 @@
>  #include "event-parse.h"
>  
>  static unsigned long long
> -process___le16_to_cpup(struct trace_seq *s,
> -		       unsigned long long *args)
> +process___le16_to_cpup(struct trace_seq *s, unsigned long long *args)
>  {
>  	uint16_t *val = (uint16_t *) (unsigned long) args[0];
>  	return val ? (long long) le16toh(*val) : 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists