linux-kernel - Re: [PATCH] ARM: STi: DT: Properly define sti-ethclk & stmmaceth for stih415/6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140616091942.GA27978@griffinp-ThinkPad-X1-Carbon-2nd>
Date:	Mon, 16 Jun 2014 10:19:42 +0100
From:	Peter Griffin <peter.griffin@...aro.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	maxime.coquelin@...com, patrice.chotard@...com,
	srinivas.kandagatla@...il.com, gabriel.fernandez@...com,
	daniel.thompson@...aro.org
Subject: Re: [PATCH] ARM: STi: DT: Properly define sti-ethclk & stmmaceth for
 stih415/6

Hi Lee,

> >  		ethernet1: dwmac@...08000 {
> > @@ -189,11 +189,11 @@
> >  			st,syscon		= <&syscfg_sbc>;
> >  
> >  			resets			= <&softreset STIH415_ETH1_SOFTRESET>;
> > -			reset-names		= "stmmaceth";
> > +			reset-names		= "stmmaceth", "sti-ethclk";
> >  			pinctrl-names 	= "default";
> >  			pinctrl-0	= <&pinctrl_mii1>;
> >  			clock-names	= "stmmaceth";
> > -			clocks		= <&clk_s_a0_ls CLK_ETH1_PHY>;
> > +			clocks		= <&clk_s_a0_ls CLK_ICN_REG>, <&clk_s_a0_ls CLK_ETH1_PHY>;
> 
> This looks wrong to me.  You appear to have changed the reset-names
> instead of the clock-names here.

Whoops, your right, I'll send a V2 shortly.

Pete.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/