linux-kernel - Re: [PATCH v2] drbd: change one-bit bitfield to be an unsigned int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1406160225510.30205@chino.kir.corp.google.com>
Date:	Mon, 16 Jun 2014 02:28:57 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Martin Kepplinger <martink@...teo.de>
cc:	drbd-dev@...ts.linbit.com, drbd-user@...ts.linbit.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drbd: change one-bit bitfield to be an unsigned int

On Sun, 15 Jun 2014, Martin Kepplinger wrote:

> The one-bit bitfield has no negative values and thus becomes an
> unsigned int.
> 
> Signed-off-by: Martin Kepplinger <martink@...teo.de>

I'm unsure what you're correcting here.  These bitfields are inherently 
signed, "int local:1" and "int waiting:1" are signed.  They can have one 
of two values, 0 or -1.  So I don't know what you're saying in your 
changelog.

This patch would only make sense if something is testing `local' or 
`waiting' to be equal to 1.  Is that what you're fixing?  If so, please 
specify it in the changelog with an example.

> ---
> Sorry for the visually ugly first patch. Take this one, if any.
> 
> thanks,
>                      martin
> 
> 
>  drivers/block/drbd/drbd_interval.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/block/drbd/drbd_interval.h b/drivers/block/drbd/drbd_interval.h
> index f38fcb0..8d670e6 100644
> --- a/drivers/block/drbd/drbd_interval.h
> +++ b/drivers/block/drbd/drbd_interval.h
> @@ -9,8 +9,8 @@ struct drbd_interval {
>  	sector_t sector;	/* start sector of the interval */
>  	unsigned int size;	/* size in bytes */
>  	sector_t end;		/* highest interval end in subtree */
> -	int local:1		/* local or remote request? */;
> -	int waiting:1;
> +	unsigned int local:1;	/* local or remote request? */
> +	unsigned int waiting:1;
>  };
>  
>  static inline void drbd_clear_interval(struct drbd_interval *i)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/