linux-kernel - Re: [Xen-devel] [PATCH v5 7/7] arch/x86: Comment out efi_set_rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <539EDAE9.7000605@suse.com>
Date:	Mon, 16 Jun 2014 13:54:17 +0200
From:	Juergen Gross <jgross@...e.com>
To:	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Daniel Kiper <daniel.kiper@...cle.com>
CC:	mjg59@...f.ucam.org, jeremy@...p.org, linux-efi@...r.kernel.org,
	ian.campbell@...rix.com, andrew.cooper3@...rix.com, x86@...nel.org,
	linux-kernel@...r.kernel.org, matt.fleming@...el.com,
	tglx@...utronix.de, david.vrabel@...rix.com, jbeulich@...e.com,
	hpa@...or.com, xen-devel@...ts.xenproject.org,
	boris.ostrovsky@...cle.com, mingo@...hat.com, eshelton@...ox.com
Subject: Re: [Xen-devel] [PATCH v5 7/7] arch/x86: Comment out efi_set_rtc_mmss()

On 06/16/2014 01:43 PM, Stefano Stabellini wrote:
> On Fri, 13 Jun 2014, Daniel Kiper wrote:
>> efi_set_rtc_mmss() is never used to set RTC due to bugs found
>> on many EFI platforms. It is set directly by mach_set_rtc_mmss().
>>
>> Signed-off-by: Daniel Kiper <daniel.kiper@...cle.com>
>> ---
>>   arch/x86/platform/efi/efi.c |    6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
>> index deb4f05..bd3e080 100644
>> --- a/arch/x86/platform/efi/efi.c
>> +++ b/arch/x86/platform/efi/efi.c
>> @@ -244,6 +244,11 @@ static efi_status_t __init phys_efi_set_virtual_address_map(
>>   	return status;
>>   }
>>
>> +#if 0
>> +/*
>> + * efi_set_rtc_mmss() is never used to set RTC due to bugs found
>> + * on many EFI platforms. It is set directly by mach_set_rtc_mmss().
>> + */
>>   int efi_set_rtc_mmss(const struct timespec *now)
>>   {
>>   	unsigned long nowtime = now->tv_sec;
>> @@ -279,6 +284,7 @@ int efi_set_rtc_mmss(const struct timespec *now)
>>   	}
>>   	return 0;
>>   }
>> +#endif
>
> "Commenting out" code like that is not a good idea: it leaves
> dead-rotting functions in the middle of your source file.
>
> If the function is not used, just go ahead and remove it. We can use git
> to get it back.

And shouldn't it be removed from include/linux/efi.h as well?

Juergen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/