linux-kernel - Re: [PATCH] [media] sms: Remove CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1402922329.30599.10.camel@x220>
Date:	Mon, 16 Jun 2014 14:38:49 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Mauro Carvalho Chehab <m.chehab@...sung.com>
Cc:	Martin Walch <walch.martin@....de>, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [media] sms: Remove CONFIG_ prefix from Kconfig symbols

On Wed, 2014-04-16 at 17:47 +0200, Paul Bolle wrote:
> Remove the CONFIG_ prefix from two Kconfig symbols in a dependency for
> SMS_SIANO_DEBUGFS. This prefix is invalid inside Kconfig files.
> 
> Note that the current (common sense) dependency on SMS_USB_DRV and
> SMS_SDIO_DRV being equal ensures that SMS_SIANO_DEBUGFS will not
> violate its constraints. These constraint are that:
> - it should only be built if SMS_USB_DRV is set;
> - it can't be builtin if USB support is modular.
> 
> So drop the dependency on SMS_USB_DRV, as it is unneeded.
> 
> Fixes: 6c84b214284e ("[media] sms: fix randconfig building error")
> Reported-by: Martin Walch <walch.martin@....de>
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
> This is not runtime tested, as I don't have the hardware.
> 
> A matrix of the three cases in which this symbol can be set, to aid
> review and to see whether I actually understood the constraints:
> 
> USB  SMS_USB_DRV  SMS_SDIO_DRV  SMS_SIANO_MDTV  SMS_SIANO_DEBUGFS
> m    m            m             m               y 
> y    m            m             m               y 
> y    y            y             y               y 
> 
> By the way, I found myself staring at the entries in this file for quite
> some time. Perhaps things would have been easier to understand if
> SMS_USB_DRV and SMS_SDIO_DRV both selected SMS_SIANO_MDTV. But I didn't
> dare to test that idea.

This can still be seen in v3.16-rc1 and in next-20140616.

Debugfs for smsdvb has been unbuildable since v3.12. That problem has
been reported even before v3.12 was released. Does no one care and can
it be removed?

>  drivers/media/common/siano/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/common/siano/Kconfig b/drivers/media/common/siano/Kconfig
> index f953d33ee151..4bfbd5f463d1 100644
> --- a/drivers/media/common/siano/Kconfig
> +++ b/drivers/media/common/siano/Kconfig
> @@ -22,8 +22,7 @@ config SMS_SIANO_DEBUGFS
>  	bool "Enable debugfs for smsdvb"
>  	depends on SMS_SIANO_MDTV
>  	depends on DEBUG_FS
> -	depends on SMS_USB_DRV
> -	depends on CONFIG_SMS_USB_DRV = CONFIG_SMS_SDIO_DRV
> +	depends on SMS_USB_DRV = SMS_SDIO_DRV
>  
>  	---help---
>  	  Choose Y to enable visualizing a dump of the frontend


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/