| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1402924639-5164-22-git-send-email-peter@hurleysoftware.com> Date: Mon, 16 Jun 2014 09:17:18 -0400 From: Peter Hurley <peter@...leysoftware.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org, One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>, Peter Hurley <peter@...leysoftware.com> Subject: [PATCH tty-next 21/22] serial: core: Remove superfluous ldisc flush from uart_close() The tty_ldisc_flush() after port hardware shutdown is unnecessary; the ldisc flush was just performed before the hardware shutdown in tty_port_close_start() and the ldisc will be released when uart_close() returns (because the last port close implies the last tty close). Signed-off-by: Peter Hurley <peter@...leysoftware.com> --- drivers/tty/serial/serial_core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index 212ee07..15212d7 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -1351,9 +1351,6 @@ static void uart_close(struct tty_struct *tty, struct file *filp) mutex_lock(&port->mutex); uart_shutdown(tty, state); - - tty_ldisc_flush(tty); - tty_port_tty_set(port, NULL); tty->closing = 0; spin_lock_irqsave(&port->lock, flags); -- 2.0.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists