linux-kernel - Re: [PATCH tty-next 17/22] tty: Remove ASYNC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140616135251.GK732@axis.com>
Date:	Mon, 16 Jun 2014 15:52:51 +0200
From:	Jesper Nilsson <jesper.nilsson@...s.com>
To:	Peter Hurley <peter@...leysoftware.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux-s390@...r.kernel.org, Mikael Starvik <starvik@...s.com>,
	Jesper Nilsson <jespern@...s.com>, linux-cris-kernel@...s.com,
	Samuel Ortiz <samuel@...tiz.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH tty-next 17/22] tty: Remove ASYNC_CLOSING

On Mon, Jun 16, 2014 at 09:17:14AM -0400, Peter Hurley wrote:
> Since at least before 2.6.30, tty drivers that do not drop the tty lock
> while closing cannot observe ASYNC_CLOSING set while holding the
> tty lock; this includes the tty driver's open() and hangup() methods,
> since the tty core calls these methods holding the tty lock.
> 
> For these drivers, waiting for ASYNC_CLOSING to clear while opening
> is not required, since this condition cannot occur. Similarly, even
> when the open() method drops and reacquires the tty lock after
> blocking, ASYNC_CLOSING cannot be set (again, for drivers that
> do not drop the tty lock while closing).
> 
> Now that tty port drivers no longer drop the tty lock while closing
> (since 'tty: Remove tty_wait_until_sent_from_close()'), the same
> conditions apply: waiting for ASYNC_CLOSING to clear while opening
> is not required, nor is re-checking ASYNC_CLOSING after dropping and
> reacquiring the tty lock while blocking (eg., in *_block_til_ready()).
> 
> Since ASYNC_CLOSING is not tested elsewhere, it is safe to remove
> the flag.
> 
> CC: Martin Schwidefsky <schwidefsky@...ibm.com>
> CC: Heiko Carstens <heiko.carstens@...ibm.com>
> CC: linux-s390@...r.kernel.org
> CC: Mikael Starvik <starvik@...s.com>

For the CRIS part:

Acked-by: Jesper Nilsson <jesper.nilsson@...s.com>

> CC: linux-cris-kernel@...s.com
> CC: Samuel Ortiz <samuel@...tiz.org>
> CC: "David S. Miller" <davem@...emloft.net>
> Signed-off-by: Peter Hurley <peter@...leysoftware.com>

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/