linux-kernel - Re: [PATCH] Frees gate after if statement in clk-sunxi.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 15 Jun 2014 23:21:39 -0400
From:	Nick Krause <xerofoify@...il.com>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:	Emilio López <emilio@...pez.com.ar>,
	Mike Turquette <mturquette@...aro.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] Frees gate after if statement in clk-sunxi.c

New Patch Just Fixed Typo for my email client.
Signed-off-by: Nick <xerofoify@...il.com>
---
 drivers/clk/sunxi/clk-sunxi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/sunxi/clk-sunxi.
c b/drivers/clk/sunxi/clk-sunxi.c
index 4264834..6f4fc51 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct
device_node *node)
        u32 rate;

        if (of_property_read_u32(node, "clock-frequency", &rate))
+               kfree(gate);
                return;

        /* allocate fixed-rate and gate clock structs */
Cheers Nick

On Sun, Jun 15, 2014 at 4:30 PM, Maxime Ripard
<maxime.ripard@...e-electrons.com> wrote:
> On Sat, Jun 14, 2014 at 02:11:48PM -0400, Nick wrote:
>> Signed-off-by: Nick <xerofoify@...il.com>
>
> This should be your full real name here.
>
>> ---
>>  drivers/clk/sunxi/clk-sunxi.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
>> index 4264834..6f4fc51 100644
>> --- a/drivers/clk/sunxi/clk-sunxi.c
>> +++ b/drivers/clk/sunxi/clk-sunxi.c
>> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
>>       u32 rate;
>>
>>       if (of_property_read_u32(node, "clock-frequency", &rate))
>> +             kree(gate);
>
> There's a typo in kfree. How does that even compile?
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/