linux-kernel - Re: [PATCHv3]Checks for Null value in function *get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Jun 2014 10:18:39 -0500
From:	Steve Wise <swise@...ngridcomputing.com>
To:	Nick Krause <xerofoify@...il.com>, Levente Kurusa <levex@...ux.com>
CC:	swise@...lsio.com, roland@...nel.org, sean.hefty@...el.com,
	hal.rosenstock@...il.com, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3]Checks for Null value in function *get_skub


On 6/16/2014 10:14 AM, Nick Krause wrote:
> >From what I know yes so I would close the bug at the the link in
> my previous email and just void my patch.
> Cheers Nick

We shouldn't be kfree-ing an skb anyway.  Should use kfree_skb().

There is still a leak if skb is non-null and the skb is non linear or 
cloned.


> On Mon, Jun 16, 2014 at 11:12 AM, Levente Kurusa <levex@...ux.com> wrote:
>> On 06/16/2014 05:08 PM, Nicholas Krause wrote:
>>> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
>>> ---
>>>    drivers/infiniband/hw/cxgb4/cm.c | 8 +++-----
>>>    1 file changed, 3 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/infiniband/hw/cxgb4/cm.c
>>> b/drivers/infiniband/hw/cxgb4/cm.c
>>> index f9477e2..2d56983 100644
>>> --- a/drivers/infiniband/hw/cxgb4/cm.c
>>> +++ b/drivers/infiniband/hw/cxgb4/cm.c
>>> @@ -340,15 +340,13 @@ static int status2errno(int status)
>>>     */
>>>    static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp)
>>>    {
>>>    if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) {
>>>                   skb_trim(skb, 0);
>>>                   skb_get(skb);
>>>                   skb_reset_transport_header(skb);
>>>          } else {
>>> +               if (skb)
>>> +                       kfree (skb);
>>>                  skb = alloc_skb(len, gfp);
>>>          }
>>>          t4_set_arp_err_handler(skb, NULL, NULL);
>>>
>> Isn't kfree(NULL) legal?
>>
>> (i.e. the if statement is useless)
>>
>> Thanks,
>>      Levente Kurusa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/