linux-kernel - Re: [PATCH] arch: metag: mm: hugetlbpage.c: Fix to remove null pointer checks that could never happen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <539F0CF7.7010108@imgtec.com>
Date:	Mon, 16 Jun 2014 16:27:51 +0100
From:	James Hogan <james.hogan@...tec.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	<linux-metag@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch: metag: mm: hugetlbpage.c:  Fix to remove null pointer
 checks that could never happen

On 30/05/14 00:11, Rickard Strandqvist wrote:
> Removal of null pointer checks that could never happen
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>

Applied, thanks
James

> ---
>  arch/metag/mm/hugetlbpage.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/metag/mm/hugetlbpage.c b/arch/metag/mm/hugetlbpage.c
> index 0424315..e89c843 100644
> --- a/arch/metag/mm/hugetlbpage.c
> +++ b/arch/metag/mm/hugetlbpage.c
> @@ -178,7 +178,7 @@ new_search:
>  				mm->context.part_huge = 0;
>  			return addr;
>  		}
> -		if (vma && (vma->vm_flags & MAP_HUGETLB)) {
> +		if ((vma->vm_flags & MAP_HUGETLB)) {
>  			/* space after a huge vma in 2nd level page table? */
>  			if (vma->vm_end & HUGEPT_MASK) {
>  				after_huge = 1;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/