linux-kernel - Re: [PATCH v4 2/2] mmc: sdhci: Replace host->mmc with mmc where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Jun 2014 10:06:56 -0700
From:	Markus Mayer <markus.mayer@...aro.org>
To:	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	Chris Ball <chris@...ntf.net>, Tim Kryger <tim.kryger@...il.com>,
	Mike Looijmans <mike.looijmans@...ic.nl>,
	Andrew Bresticker <abrestic@...omium.org>,
	Linux MMC List <linux-mmc@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 2/2] mmc: sdhci: Replace host->mmc with mmc where possible

On 16 June 2014 01:23, Ulf Hansson <ulf.hansson@...aro.org> wrote:
> On 13 June 2014 19:13, Markus Mayer <markus.mayer@...aro.org> wrote:
>> After the switch to the MMC core regulator infrastucture, we already
>> have a local "mmc" pointer in various functions. There is no longer a
>> need to access the data structure via host->mmc.
>>
>> Signed-off-by: Markus Mayer <markus.mayer@...aro.org>
>> Reviewed-by: Matt Porter <mporter@...aro.org>
>
> Could you run checkpatch? There were some warnings to handle.

You're right. There are several warnings regarding wrapped strings.
However, those warnings are unrelated to my changes. The wrapped
strings exist in current code.

See for instance:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/mmc/host/sdhci.c?id=refs/tags/v3.16-rc1#n1730

I don't think I should intermix my "host->mmc to mmc" replacement
patch with changes to fix the wrapping of strings.

If you would like these string related checkpatch warnings fixed, I
can look into creating a follow-on patch to fix those up. There are
quite a few more instances in sdhci.c that wouldn't get addressed if I
simply fixed up my existing patch. And that would be the other
argument against intermixing 2 different fixes: I wouldn't be taking
care of all string wrapping issues if I just fixed the four instances
it complains about in my patch.

Some of those wrapped strings are actually quite long. Here's an example:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/mmc/host/sdhci.c?id=refs/tags/v3.16-rc1#n1938

So, fixing those long messages may take a bit more thought than one
might initially expect.

Please let me know how you would like to proceed.

Thanks,
-Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/