linux-kernel - Re: [PATCH 09/13] purgatory: Core purgatory functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Jun 2014 13:25:38 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	linux-kernel@...r.kernel.org, kexec@...ts.infradead.org,
	ebiederm@...ssion.com, hpa@...or.com, mjg59@...f.ucam.org,
	greg@...ah.com, jkosina@...e.cz, dyoung@...hat.com,
	chaowang@...hat.com, bhe@...hat.com, akpm@...ux-foundation.org
Subject: Re: [PATCH 09/13] purgatory: Core purgatory functionality

On Fri, Jun 13, 2014 at 12:17:13PM +0200, Borislav Petkov wrote:
> On Fri, Jun 06, 2014 at 03:51:04PM -0400, Vivek Goyal wrote:
> > On Thu, Jun 05, 2014 at 10:05:23PM +0200, Borislav Petkov wrote:
> > 
> > [..]
> > > > @@ -249,6 +254,7 @@ archclean:
> > > >  	$(Q)rm -rf $(objtree)/arch/x86_64
> > > >  	$(Q)$(MAKE) $(clean)=$(boot)
> > > >  	$(Q)$(MAKE) $(clean)=arch/x86/tools
> > > 
> > > ifeq ($(CONFIG_KEXEC),y)
> > > 	$(Q)$(MAKE) $(clean)=arch/x86/purgatory
> > > endif
> > 
> > Hmm.., is it strictly required? I am wondering what happens if I build
> > a kernel with CONFIG_KEXEC=y, then set CONFIG_KEXEC=n and do "make clean".
> 
> Try it - it works here.
> 
> > I think I will still like any files in arch/x86/purgatory to be cleaned
> > despite the fact that CONFIG_KEXEC=n. Isn't it?
> 
> Yep, that works. Conversely, we don't want people who haven't enabled
> KEXEC ever to have unrelated cleanup delay.
> 

I tried following with CONFIG_KEXEC=n

ifeq ($(CONFIG_KEXEC),y)
        $(Q)$(MAKE) $(clean)=arch/x86/purgatory
endif

And still "make V=1 clean" shows me that it is going in purgatory dir
to clean things up.

make -f scripts/Makefile.clean obj=arch/x86/purgatory

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/