linux-kernel - Re: [PATCH v5 4/7] xen: Put EFI machinery in place

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Jun 2014 21:06:23 +0200
From:	Daniel Kiper <daniel.kiper@...cle.com>
To:	David Vrabel <david.vrabel@...rix.com>
Cc:	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
	x86@...nel.org, xen-devel@...ts.xenproject.org,
	andrew.cooper3@...rix.com, boris.ostrovsky@...cle.com,
	eshelton@...ox.com, hpa@...or.com, ian.campbell@...rix.com,
	jbeulich@...e.com, jeremy@...p.org, konrad.wilk@...cle.com,
	matt.fleming@...el.com, mingo@...hat.com, mjg59@...f.ucam.org,
	stefano.stabellini@...citrix.com, tglx@...utronix.de
Subject: Re: [PATCH v5 4/7] xen: Put EFI machinery in place

On Mon, Jun 16, 2014 at 01:00:29PM +0100, David Vrabel wrote:
> On 13/06/14 18:00, Daniel Kiper wrote:
> >
> > v5 - suggestions/fixes:
>
> Put after a --- marker.

Why?

You mean:

---

v5 - suggestions/fixes:
...

> > +static efi_char16_t vendor[100] __initdata;
>
> Why 100?

Well... Quite arbitrary value. The same thing is used in
arch/x86/platform/efi/efi.c:efi_init(). Sadly UEFI sepec
says nothing about maximum vendor name length.

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/