lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 16 Jun 2014 14:40:43 +0900
From:	Joonsoo Kim <>
To:	Andrew Morton <>,
	"Aneesh Kumar K.V" <>,
	Marek Szyprowski <>,
	Michal Nazarewicz <>
Cc:	Minchan Kim <>,
	Russell King - ARM Linux <>,
	Greg Kroah-Hartman <>,
	Paolo Bonzini <>,
	Gleb Natapov <>, Alexander Graf <>,
	Benjamin Herrenschmidt <>,
	Paul Mackerras <>,,,,,,,
	Zhang Yanfei <>,
	Joonsoo Kim <>
Subject: [PATCH v3 -next 1/9] DMA, CMA: fix possible memory leak

We should free memory for bitmap when we find zone mis-match,
otherwise this memory will leak.

Additionally, I copy code comment from PPC KVM's CMA code to inform
why we need to check zone mis-match.

* Note
Minchan suggested to add a tag for the stable, but, I don't do it,
because I found this possibility during code-review and, IMO,
this patch isn't suitable for stable tree.

Acked-by: Zhang Yanfei <>
Reviewed-by: Michal Nazarewicz <>
Reviewed-by: Aneesh Kumar K.V <>
Signed-off-by: Joonsoo Kim <>

diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c
index 83969f8..6467c91 100644
--- a/drivers/base/dma-contiguous.c
+++ b/drivers/base/dma-contiguous.c
@@ -176,14 +176,24 @@ static int __init cma_activate_area(struct cma *cma)
 		base_pfn = pfn;
 		for (j = pageblock_nr_pages; j; --j, pfn++) {
+			/*
+			 * alloc_contig_range requires the pfn range
+			 * specified to be in the same zone. Make this
+			 * simple by forcing the entire CMA resv range
+			 * to be in the same zone.
+			 */
 			if (page_zone(pfn_to_page(pfn)) != zone)
-				return -EINVAL;
+				goto err;
 	} while (--i);
 	return 0;
+	kfree(cma->bitmap);
+	return -EINVAL;
 static struct cma cma_areas[MAX_CMA_AREAS];

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists