linux-kernel - Re: [PATCH] clkdev: Don't print errors on probe defer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140617223305.32686.15540@quantum>
Date:	Tue, 17 Jun 2014 15:33:05 -0700
From:	Mike Turquette <mturquette@...aro.org>
To:	Stephen Boyd <sboyd@...eaurora.org>,
	"Russell King" <linux@....linux.org.uk>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] clkdev: Don't print errors on probe defer

Quoting Stephen Boyd (2014-06-13 16:36:31)
> This error message can spam the logs if you have lots of probe
> deferals due to missing clocks. Just silence the error in this
> case because the driver should try again later.
> 
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>

Looks OK to me. Russell?

Regards,
Mike

> ---
>  drivers/clk/clkdev.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> index f890b901c6bc..da4bda8b7fc7 100644
> --- a/drivers/clk/clkdev.c
> +++ b/drivers/clk/clkdev.c
> @@ -101,8 +101,9 @@ struct clk *of_clk_get_by_name(struct device_node *np, const char *name)
>                 if (!IS_ERR(clk))
>                         break;
>                 else if (name && index >= 0) {
> -                       pr_err("ERROR: could not get clock %s:%s(%i)\n",
> -                               np->full_name, name ? name : "", index);
> +                       if (PTR_ERR(clk) != -EPROBE_DEFER)
> +                               pr_err("ERROR: could not get clock %s:%s(%i)\n",
> +                                       np->full_name, name ? name : "", index);
>                         return clk;
>                 }
>  
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/