linux-kernel - Re: [PATCH] include: kernel.h: rewrite min3, max3 and clamp using min and max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140616202120.27364ed9@gandalf.local.home>
Date:	Mon, 16 Jun 2014 20:21:20 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Michal Nazarewicz <mina86@...a86.com>,
	Hagen Paul Pfeifer <hagen@...u.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] include: kernel.h: rewrite min3, max3 and clamp using
 min and max

On Mon, 16 Jun 2014 16:54:32 -0700 (PDT)
David Rientjes <rientjes@...gle.com> wrote:

> 
> 
> On linux-next, allyesconfig has a 0.0001% savings as a result of the 
> patch, but I'd be worried about the extra temp variable it allocates on 
> the stack that is evident in the mm/slab.c disassembly unless all cases 
> can be audited to show that we're not potentially deep.

A 0.0001% change means it's not worth changing, and we may be able to
mark this up as a fluke in Michal's results.

I'll give it a try on my 4.6.3 compiler.

-- Steve

> 
>    text	   data	    bss	    dec	    hex	filename
> 108573045	23488016	51580928	183641989	af22785	vmlinux.before
> 108572908	23488016	51580928	183641852	af226fc	vmlinux.after

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/