linux-kernel - Re: [PATCH] Check if skb_alloc returns Null in function fw_download_code

Open Source and information security mailing list archives

Message-ID: <20140617060746.GL5500@mwanda>
Date:	Tue, 17 Jun 2014 09:07:46 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	ben@...adent.org.uk, lisa@...apiadmin.com,
	valentina.manea.m@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Check if skb_alloc returns Null in function
 fw_download_code

On Mon, Jun 16, 2014 at 11:23:13PM -0400, Nicholas Krause wrote:
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> index 1a95d1f..11e915e 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> @@ -61,11 +61,13 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
>  		}
>  
>  		skb  = dev_alloc_skb(frag_length + 4);
> +		if (!skb) {

This test is reversed and causes a NULL dereference on the next line.

regards,
dan carpenter

>  		memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
>  		tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
>  		tcb_desc->queue_index = TXCMD_QUEUE;
>  		tcb_desc->bCmdOrInit = DESC_PACKET_TYPE_INIT;
>  		tcb_desc->bLastIniPkt = bLastIniPkt;
> +		}
>  
>  		seg_ptr = skb->data;
>  		for (i = 0; i < frag_length; i += 4) {
> -- 
> 1.9.1
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives