linux-kernel - Re: [PATCH] gpio-pxa: gpio0 and gpio1 support on dt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN1soZz__VrLj57yLVTgqLnEUnS2wqaAv71kwnbZ5oRCVVoCNw@mail.gmail.com>
Date:	Tue, 17 Jun 2014 08:18:36 +0800
From:	Haojian Zhuang <haojian.zhuang@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Andrew Ruder <andrew.ruder@...csyscorp.com>,
	Marek Vašut <marek.vasut@...il.com>,
	Eric Miao <eric.y.miao@...il.com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Alexandre Courbot <gnurou@...il.com>
Subject: Re: [PATCH] gpio-pxa: gpio0 and gpio1 support on dt

On Thu, Jun 12, 2014 at 4:43 PM, Linus Walleij <linus.walleij@...aro.org> wrote:
> On Thu, Jun 5, 2014 at 9:13 PM, Andrew Ruder
> <andrew.ruder@...csyscorp.com> wrote:
>
>> pxa_gpio_probe() has some issues supporting the gpio0 and gpio1
>> interrupts under device-tree - it never actually sets up the chain
>> handler to get interrupts on edge detect for GPIO0 and GPIO1.
>>
>> Signed-off-by: Andrew Ruder <andrew.ruder@...csyscorp.com>
>
> Makes perfect sense. Can I have an ACK from some PXA
> maintainer on this?
>
> The PXA GPIO driver with it's messy irqchip registration looks
> like a good candidate for switching to the gpiolib irqchip helpers
> and rid some code. Just saying.
>
> Yours,
> Linus Walleij

Acked-by: Haojian Zhuang <haojian.zhuang@...il.com>

Yes, it's worth to rid some irqchip code.

Regards
Haojian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/