linux-kernel - RE: [PATCH] infiniband: Fixes memory leak in send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <002201cf8a33$740fc730$5c2f5590$@opengridcomputing.com>
Date:	Tue, 17 Jun 2014 08:53:01 -0500
From:	"Steve Wise" <swise@...ngridcomputing.com>
To:	"'David Rientjes'" <rientjes@...gle.com>,
	"'Nick Krause'" <xerofoify@...il.com>
Cc:	<swise@...lsio.com>, <roland@...nel.org>, <sean.hefty@...el.com>,
	<hal.rosenstock@...il.com>, <linux-rdma@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] infiniband: Fixes memory leak in send_flowc



> -----Original Message-----
> From: linux-rdma-owner@...r.kernel.org [mailto:linux-rdma-owner@...r.kernel.org] On
> Behalf Of David Rientjes
> Sent: Monday, June 16, 2014 7:37 PM
> To: Nick Krause
> Cc: Steve Wise; swise@...lsio.com; roland@...nel.org; sean.hefty@...el.com;
> hal.rosenstock@...il.com; linux-rdma@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] infiniband: Fixes memory leak in send_flowc
> 
> On Mon, 16 Jun 2014, Nick Krause wrote:
> 
> > That's true David,
> > I will resend this parch without the use of the pr_warn.
> 
> There's no patch to resend if you don't use pr_warn().  kfree_skb(skb) is
> unnecessary if !skb, look at the first thing it checks:
> 
> void kfree_skb(struct sk_buff *skb)
> {
>         if (unlikely(!skb))
>                 return;
> 	...
> }
> 
> Thus, I don't see the memory leak you're referring to.

send_flowc() still needs to handle a NULL return from get_skb().  That is what the bug
report is addressing...

Steve.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/