lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Jun 2014 10:26:10 -0400 (EDT) From: Alan Stern <stern@...land.harvard.edu> To: Tuomas Tynkkynen <ttynkkynen@...dia.com> cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org>, <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] USB: EHCI: tegra: Fix use-after-free in .remove() On Tue, 17 Jun 2014, Tuomas Tynkkynen wrote: > The tegra_ehci_hcd structure is located in the private space allocated > by the core USB code so it must not be accessed after the HCD is > freed. > > Signed-off-by: Tuomas Tynkkynen <ttynkkynen@...dia.com> > --- > drivers/usb/host/ehci-tegra.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c > index 6fdcb8a..5590567 100644 > --- a/drivers/usb/host/ehci-tegra.c > +++ b/drivers/usb/host/ehci-tegra.c > @@ -479,10 +479,11 @@ static int tegra_ehci_remove(struct platform_device *pdev) > > usb_phy_shutdown(hcd->phy); > usb_remove_hcd(hcd); > - usb_put_hcd(hcd); > > clk_disable_unprepare(tegra->clk); > > + usb_put_hcd(hcd); > + > return 0; > } Acked-by: Alan Stern <stern@...land.harvard.edu> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists