linux-kernel - Re: [PATCH 4/5] mfd: arizona: Use num_core_supplies in arizona_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140617143631.GE29841@lee--X1>
Date:	Tue, 17 Jun 2014 15:36:31 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	sameo@...ux.intel.com, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] mfd: arizona: Use num_core_supplies in
 arizona_dev_exit

On Mon, 02 Jun 2014, Charles Keepax wrote:

> Currently we call regulator_bulk_disable with
> ARRAY_SIZE(arizona->core_supplies), however this array may be larger
> than the number of supplies actually used by the chip we are dealing
> with. Use the provided num_core_supplies member instead, so that we only
> disable supplies which actually exist.
> 
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
>  drivers/mfd/arizona-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 7678e84..51c0110 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -1039,7 +1039,7 @@ int arizona_dev_exit(struct arizona *arizona)
>  	if (arizona->pdata.reset)
>  		gpio_set_value_cansleep(arizona->pdata.reset, 0);
>  
> -	regulator_bulk_disable(ARRAY_SIZE(arizona->core_supplies),
> +	regulator_bulk_disable(arizona->num_core_supplies,
>  			       arizona->core_supplies);
>  	return 0;
>  }

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/