linux-kernel - Re: [PATCH 1/2] regulator: max1586 add device-tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140617144323.GU5099@sirena.org.uk>
Date:	Tue, 17 Jun 2014 15:43:23 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:	Liam Girdwood <lgirdwood@...il.com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] regulator: max1586 add device-tree support

On Sat, Jun 14, 2014 at 04:54:24PM +0200, Robert Jarzmik wrote:

> +	matched = of_regulator_match(dev, np, rmatch, ARRAY_SIZE(rmatch));
> +	of_node_put(np);
> +	if (matched <= 0)
> +		return matched;

Why is this treating zero as an error?  We should be able to at least
report the current state of regulators even if none are configured in
the device tree.

Otherwise this looks good.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)