linux-kernel - Re: [PATCH 2/2] mfd: arizona: Destroy regulators after the other MFD cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140617151642.GE26741@opensource.wolfsonmicro.com>
Date:	Tue, 17 Jun 2014 16:16:42 +0100
From:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	sameo@...ux.intel.com, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mfd: arizona: Destroy regulators after the other
	MFD cells

On Tue, Jun 17, 2014 at 03:54:20PM +0100, Lee Jones wrote:
> On Mon, 02 Jun 2014, Charles Keepax wrote:
> 
> > Several of the cells depend on the regulators provided by the
> > arizona-micsupp and arizona-ldo1 cells. As such use the new remove_level
> > feature of the MFD core to ensure the regulators are destroyed after all
> > the other cells.
> > 
> > Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> > ---
> >  drivers/mfd/arizona-core.c |   20 ++++++++++++++++----
> >  1 files changed, 16 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> > index 51c0110..76248bc 100644
> > --- a/drivers/mfd/arizona-core.c
> > +++ b/drivers/mfd/arizona-core.c
> > @@ -570,7 +570,10 @@ static inline int arizona_of_get_core_pdata(struct arizona *arizona)
> >  #endif
> >  
> >  static const struct mfd_cell early_devs[] = {
> > -	{ .name = "arizona-ldo1" },
> > +	{
> > +		.name = "arizona-ldo1",
> > +		.remove_level = 1,
> > +	},
> >  };
> 
> Not keen on this approach at all.
> 
> +1 for the new reverse-probe-helpers.

Yeah that does seem like a better solution, I am looking at it
but it is a little more complex than I hoped so will be a
slight delay on getting a patch out for it.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/